-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PackageSupplier interface to accept VersionRange #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a leftover of the time when everything in dub accepted Dependency. While the mess had been untangled, doing so on this interface proved harder, as there is no good way to deprecate it in a fully backward-compatible manner without introducing a lot of overhead (a new type). Instead, this uses a middle ground approach, where the external implementers (which most likely do not exists) would break (although the fix is trivial), but callers would not.
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5331080 bin/dub
-rough build time=66s
+executable size=5335176 bin/dub
+rough build time=65s Full build output
|
thewilsonator
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover of the time when everything in dub accepted Dependency. While the mess had been untangled, doing so on this interface proved harder, as there is no good way to deprecate it in a fully backward-compatible manner without introducing a lot of overhead (a new type). Instead, this uses a middle ground approach, where the external implementers (which most likely do not exists) would break (although the fix is trivial), but callers would not.