-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Move single checks to Github, remove dead code #2828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5343584 bin/dub
rough build time=62s Full build output
|
thewilsonator
approved these changes
Jan 23, 2024
Geod24
force-pushed
the
mlang/Coverage3
branch
2 times, most recently
from
January 23, 2024 13:29
26b6c9d
to
1e2377b
Compare
Remove support for very old frontend - we were not testing it anyways. Move the useful checks to another job so they run once.
Geod24
force-pushed
the
mlang/Coverage3
branch
from
January 23, 2024 13:37
1e2377b
to
defece2
Compare
Just tested that the trailing whitespace check works as it triggered :) |
PetarKirov
reviewed
Jan 24, 2024
- name: Run tests | ||
run: | | ||
# check for trailing whitespace | ||
TRAILING_WS_COUNT=$(find . -type f -name '*.d' -exec grep -Hn "[[:blank:]]$" {} \; | wc -l) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be replaced by:
https://github.com/marketplace/actions/editorconfig-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for very old frontend - we were not testing it anyways. Move the useful checks to another job so they run once.