Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for OMF, make MsCOFF be x86 #2916

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jun 3, 2024

Now that OMF support is being removed, dmd-latest is broken in the CI. Since DMD no longer supports it, and we are mostly concerned about supporting the latest 10 releases, we're keeping x86_omf and x86_mscoff available but making them aliases to x86.

Copy link

github-actions bot commented Jun 3, 2024

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5259448 bin/dub
-rough build time=60s
+rough build time=61s
Full build output
DUB version 1.37.0, built on May 11 2024
LDC - the LLVM D compiler (1.38.0):
  based on DMD v2.108.1 and LLVM 18.1.5
  built with LDC - the LLVM D compiler (1.38.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.38.0/x64/ldc2-1.38.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.38.0+commit.27.g1087a43d: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5259448 bin/dub
STAT:rough build time=61s

@ibuclaw
Copy link
Member

ibuclaw commented Jun 3, 2024

I think this should target stable?

Now that OMF support is being removed, dmd-latest is broken in the CI.
Since DMD no longer supports it, and we are mostly concerned about
supporting the latest 10 releases, we're keeping x86_omf and x86_mscoff
available but making them aliases to x86.
@Geod24 Geod24 changed the base branch from master to stable June 3, 2024 11:36
@Geod24
Copy link
Member Author

Geod24 commented Jun 3, 2024

Changed to stable.

@dlang-bot dlang-bot merged commit 270c8a3 into dlang:stable Jun 3, 2024
31 checks passed
@Geod24 Geod24 deleted the mlang/KillOMF branch June 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants