-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Mock IO in the Dub
class too
#2941
Open
Geod24
wants to merge
8
commits into
dlang:master
Choose a base branch
from
Geod24:mlang/FS
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR OK, no changes in deprecations or warnings Total deprecations: 8 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5297464 bin/dub
+executable size=5301560 bin/dub
rough build time=63s Full build output
|
Geod24
force-pushed
the
mlang/FS
branch
4 times, most recently
from
June 23, 2024 22:39
04512c4
to
99b5776
Compare
Geod24
force-pushed
the
mlang/FS
branch
2 times, most recently
from
June 25, 2024 08:10
b136a85
to
190d56a
Compare
thewilsonator
approved these changes
Jun 25, 2024
Geod24
force-pushed
the
mlang/FS
branch
3 times, most recently
from
June 25, 2024 16:38
81b8167
to
8b54204
Compare
Geod24
force-pushed
the
mlang/FS
branch
5 times, most recently
from
July 12, 2024 23:14
07e4824
to
fe73ed3
Compare
Geod24
force-pushed
the
mlang/FS
branch
2 times, most recently
from
September 22, 2024 12:08
b25f9db
to
44f1d91
Compare
Currently our working directory is always the root, which means that we didn't care about absolute vs relative path until now.
On Windows, the root has a name, which is the drive, unlike on POSIX where the root is an empty name. This led to a flurry of problems because we assumed a POSIX style, where the FS is a directed graph, while on Windows it is multiple unconnected graphs (the drives cannot be accessed via a relative path).
In the real world, it's unlikely Dub is ever started from the root path. However, in our current unittest framework, that is always the case.
While we don't use it yet, it allows us to remove the field from out TestDub class
This way we can start making use of the Filesystem abstraction in the Dub class.
By using the Filesystem instance we can start writing better tests, in this case getting the ability to load configurations from tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to write more tests for the Dub class. In particular I am interested in being able to write unittests around the config file, which require
loadConfig
to be callable. We still need to callthisExePath
at the moment but that can be solved later as it has no visible side effect.