MagickSettings: why options backed by Drawing are not all handled in the same way?

[Gounlaf]

👋

Looking at MagickSettings, I'm trying to understand why there is different way of handling the properties both backed in Drawing and _options:

As example:

• the getter for FillColor is backed directly from the Drawing property.
  

  Magick.NET/src/Magick.NET/Settings/MagickSettings.cs

  Lines 122 to 130 in 5676471

  	public IMagickColor<QuantumType>? FillColor
  	{
  	get => Drawing.FillColor;
  	set
  	{
  	SetOptionAndArtifact("fill", value?.ToString());
  	Drawing.FillColor = value;
  	}
  	}

• the getter for FontFamily is looking into options
  

  Magick.NET/src/Magick.NET/Settings/MagickSettings.cs

  Lines 166 to 174 in 5676471

  	public string? FontFamily
  	{
  	get => GetOption("family");
  	set
  	{
  	SetOptionAndArtifact("family", value);
  	Drawing.FontFamily = value;
  	}
  	}

Is this intentional? And why?

Thanks.

Regards.

[dlemstra]

I have no idea why I did that but it makes more sense to return Drawing.FontFamily. I really appreciate all your questions about my library and the research you are doing. Looking forward to another PR from you to fix his!

[Gounlaf]

Here it is #1521

[Gounlaf]

I have no idea why I did that [...]

I thank it was to avoid make low level/native api calls, but... nope ; the Drawing class is created with the native api, but that's all.