fix dependencies and typing

dlt-hub · Nov 7, 2024 · 64de75d · 64de75d
1 parent 500b5ff
commit 64de75d
Show file tree

Hide file tree

Showing 4 changed files with 81 additions and 7 deletions.
diff --git a/dlt/common/libs/ibis.py b/dlt/common/libs/ibis.py
@@ -7,8 +7,6 @@
 
 try:
     import ibis  # type: ignore[import-untyped]
-    from ibis import Table
-    from ibis import memtable
     from ibis import BaseBackend
 except ModuleNotFoundError:
     raise MissingDependencyException("dlt ibis Helpers", ["ibis"])

diff --git a/dlt/destinations/dataset.py b/dlt/destinations/dataset.py
@@ -24,13 +24,10 @@
 
 if TYPE_CHECKING:
     try:
-        from dlt.common.libs.ibis import Table as IbisTable
         from dlt.common.libs.ibis import BaseBackend as IbisBackend
     except MissingDependencyException:
-        IbisTable = Any
         IbisBackend = Any
 else:
-    IbisTable = Any
     IbisBackend = Any
 
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -166,6 +166,7 @@ pytest-mock = "^3.14.0"
 types-regex = "^2024.5.15.20240519"
 flake8-print = "^5.0.0"
 mimesis = "^7.0.0"
+ibis-framework = { version = ">=9.0.0", markers = "python_version >= '3.10'"}
 
 [tool.poetry.group.sources]
 optional = true