duckdb filesystem custom secrets #2017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
changed the title
rudolfix
requested changes
Nov 4, 2024
| ).fetchone()[0] | ||
|
|
||
| # TODO: what is with windows? | ||
| is_default_secrets_directory = current_secret_directory.endswith("/.duckdb/stored_secrets") |
There was a problem hiding this comment.
not going to work because windows use backslashes. ie.
D SELECT current_setting('secret_directory') AS secret_directory;
┌──────────────────────────────────────────┐
│ secret_directory │
│ varchar │
├──────────────────────────────────────────┤
│ C:\Users\rudolfix\.duckdb\stored_secrets │
└──────────────────────────────────────────┘
please use Path to compare paths
| destinations_configs(all_buckets_filesystem_configs=True, bucket_subset=(AWS_BUCKET,)), | ||
| ids=lambda x: x.name, | ||
| ) | ||
| def test_secrets_management(destination_config: DestinationTestConfiguration) -> None: |
There was a problem hiding this comment.
do we need this test in the load? if you move it to tests/pipelines it will execute on windows as well. then you'll see if you normalize the paths correctly
sh-rp
force-pushed
the
fix/duckdb_filesystem_custom_secrets
branch
2 times, most recently
from
8f5d457
to
a0828a9
Compare
test secrets on all platforms
sh-rp
force-pushed
the
fix/duckdb_filesystem_custom_secrets
branch
from
a0828a9
to
cd30eb8
Compare
sh-rp
commented
Nov 5, 2024
pytest.ini
Outdated
| @@ -1,7 +1,7 @@ | |||
| [pytest] | |||
| pythonpath= dlt docs/website/docs | |||
| norecursedirs= .direnv .eggs build dist | |||
| addopts= -v --showlocals --durations 10 | |||
There was a problem hiding this comment.
ok, somehow it does not work on ci...
sh-rp
force-pushed
the
fix/duckdb_filesystem_custom_secrets
branch
from
5741abb
to
40b8b80
Compare
sh-rp
commented
Nov 5, 2024
| @@ -89,6 +89,7 @@ alembic = {version = ">1.10.0", optional = true} | |||
| paramiko = {version = ">=3.3.0", optional = true} | |||
| sqlglot = {version = ">=20.0.0", optional = true} | |||
| db-dtypes = { version = ">=1.2.0", optional = true } | |||
| aiohttp = { version = ">=3.9", optional = true } | |||
There was a problem hiding this comment.
this seems to be needed for python 3.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note:
I tried implementing changing the secrets location in create_authentication, but somehow I could not get it right. I think this solution with warning the user should be good for now.