Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated google cloud function documentation #2034

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dat-a-man
Copy link
Collaborator

@dat-a-man dat-a-man commented Nov 7, 2024

Description

Updated Google Cloud function documentation.
This needed an update as Google no longer supports Cloud Source Repositories for new users.

@dat-a-man dat-a-man self-assigned this Nov 7, 2024
@dat-a-man dat-a-man added the documentation Improvements or additions to documentation label Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 7780995
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/672c4f8585d61000089d1e6b
😎 Deploy Preview https://deploy-preview-2034--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dat-a-man
Copy link
Collaborator Author

@hibajamal could you please do an initial review?

@hibajamal
Copy link
Contributor

seems alright to me! the language fixes really made a difference

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@AstrakhantsevaAA AstrakhantsevaAA merged commit 9c14458 into devel Nov 7, 2024
51 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the docs/update_deploy_cloud_functions_docs branch November 7, 2024 10:18
Copy link
Contributor

@hibajamal hibajamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would've approved earlier, i thought i was simply assigned (not as a reviewer) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants