Don't create listener until it's needed #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code that's using this gem as a library dependency may just want to take advantage of its rendering, not its watching, so defer creating a listener until it's needed.
Celluloid started failing in the tests with `Celluloid::Error: Celluloid is not yet started; use Celluloid.boot` again. Update the workaround to get it happy again.
Pin to github-linguist 3.3.1 to avoid problems introduced in later versions (for a number of versions they relied on a beta constant in rugged which is now gone and creates an error, and in the latest it looks like a Pygments constant that html-pipeline relies on disappeared)
dmarcotte
added a commit
that referenced
this pull request
Nov 25, 2014
Don't create listener until it's needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code that's using this gem as a library dependency may just want to take advantage of its rendering, not its watching, so defer creating a listener until it's needed.
This pull also updates deps and such to ensure tests are green, which includes pinning the optional github-linguist dep to a good version (the latest versions are currently very cranky...)