Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for a stable 1.0.0 release #246

Merged
merged 12 commits into from
Jan 12, 2021
Merged

Prepare for a stable 1.0.0 release #246

merged 12 commits into from
Jan 12, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 9, 2021

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 9, 2021

@dovahcrow Would you be able to review this? Let me know if this PR is adequate for your Rust runtime.

@dovahcrow
Copy link
Contributor

@hcho3 tbh I'm not very familiar with C++ and its build system. I can only confirm this is sufficient for building the rust runtime binding.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 9, 2021

Somehow the CI is unable to use Homebrew GCC :( Why did the CI have to break at this time, when 1.0 is about to go out ;)

@dovahcrow
Copy link
Contributor

Somehow the CI is unable to use Homebrew GCC :( Why did the CI have to break at this time, when 1.0 is about to go out ;)

Just let me know if there's anything I can help with.

I just finished nearly all the bindings of the runtime in Rust, except for reading DMatrix from file and CSR.

@codecov-io
Copy link

codecov-io commented Jan 9, 2021

Codecov Report

Merging #246 (7514d43) into mainline (792514a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #246      +/-   ##
==============================================
- Coverage       83.69%   83.69%   -0.01%     
  Complexity         44       44              
==============================================
  Files              93       93              
  Lines            6932     6937       +5     
  Branches           42       42              
==============================================
+ Hits             5802     5806       +4     
- Misses           1106     1107       +1     
  Partials           24       24              
Impacted Files Coverage Δ Complexity Δ
python/treelite/core.py 82.14% <100.00%> (+2.14%) 0.00 <0.00> (ø)
runtime/python/treelite_runtime/predictor.py 86.63% <100.00%> (+0.14%) 0.00 <0.00> (ø)
src/compiler/ast_native.cc 96.49% <0.00%> (-0.21%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792514a...7514d43. Read the comment docs.

@hcho3 hcho3 merged commit 6da9e2d into dmlc:mainline Jan 12, 2021
@hcho3 hcho3 deleted the stable_1.0.0 branch January 12, 2021 23:55
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 30, 2021
The stable 1.0.0 version of Treelite is [virtually identical to the 1.0.0 RC1 version](dmlc/treelite#246). Using `1.0.0rc1|1.0.0` so that the CI doesn't break until rapidsai/integration#210 is merged.

Authors:
  - Philip Hyunsu Cho (@hcho3)

Approvers:
  - AJ Schmidt (@ajschmidt8)

URL: #3394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants