-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for a stable 1.0.0 release #246
Conversation
@dovahcrow Would you be able to review this? Let me know if this PR is adequate for your Rust runtime. |
@hcho3 tbh I'm not very familiar with C++ and its build system. I can only confirm this is sufficient for building the rust runtime binding. |
Somehow the CI is unable to use Homebrew GCC :( Why did the CI have to break at this time, when 1.0 is about to go out ;) |
Just let me know if there's anything I can help with. I just finished nearly all the bindings of the runtime in Rust, except for reading |
Codecov Report
@@ Coverage Diff @@
## mainline #246 +/- ##
==============================================
- Coverage 83.69% 83.69% -0.01%
Complexity 44 44
==============================================
Files 93 93
Lines 6932 6937 +5
Branches 42 42
==============================================
+ Hits 5802 5806 +4
- Misses 1106 1107 +1
Partials 24 24
Continue to review full report at Codecov.
|
The stable 1.0.0 version of Treelite is [virtually identical to the 1.0.0 RC1 version](dmlc/treelite#246). Using `1.0.0rc1|1.0.0` so that the CI doesn't break until rapidsai/integration#210 is merged. Authors: - Philip Hyunsu Cho (@hcho3) Approvers: - AJ Schmidt (@ajschmidt8) URL: #3394
FetchContent_MakeAvailable
command is only for CMake 3.14+, so define it ourselves when CMake version is 3.13.libtreelite.a
,libtreelite_runtime.a
) optional to build. Add CMake optionBUILD_STATIC_LIBS
to build static libs. This is useful for building a Conda package, since Conda recipes should not build static libs for most use cases.export_lib()
with a cryptic error, and I cannot reproduce on my machine. For now, the CI should just use Apple Clang. Some tests that are known to fail with Apple Clang are marked as XFAIL.