update python docs some mistakes #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Feb 21, 2024
doc/python/callbacks.rst
Outdated
| @@ -49,7 +49,7 @@ inside iteration loop. You can also pass this callback function directly into X | |||
| verbose_eval=False) | |||
|
|
|||
| dump = booster.get_dump(dump_format='json') | |||
| assert len(early_stop.stopping_history['Valid']['CustomErr']) == len(dump) | |||
| assert len(early_stop.stopping_history['Train']['CustomErr']) == len(dump) | |||
There was a problem hiding this comment.
apologies for the mistake, I think we should modify the previous the data_name in line 39 to data_name="Valid" instead since it doesn't make sense to early stop with the training data.
There was a problem hiding this comment.
apologies for the mistake, I think we should modify the previous the
data_namein line 39 todata_name="Valid"instead since it doesn't make sense to early stop with the training data.
yes, you are right! I have changed it again, please review, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/python/callbacks.rst，the original code reported an error as follows:after change
ValidintoTrain, it is okdoc/python/sklearn_estimator.rst, the original code reported an error as follows:after change
Validation_0intovalidation_0, it is ok