-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Explicitly link with CCCL (standalone or CTK) #10624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to replace thrust as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hyunsu! 🙏
Had a couple questions below
@jakirkham It seems that for CUDA 11.8, CTK doesn't have the CMake config for CCCL:
Do we need CTK 12.0+ to access the built-in CCCL? cc @bdice |
That sounds plausible Can we just fallback to Thrust & CUB in that case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hyunsu! 🙏
Added a suggestion below
The better way to get CCCL is via GitHub or conda, rather than the CTK: https://github.com/NVIDIA/cccl?tab=readme-ov-file#github That way you can use a CCCL version that works with all the supported CTK versions, rather than having to make exceptions for every CUDA version in the build scripts. I think you need at least CCCL 2.2.0 to make things work properly with CMake, which shipped with CUDA 12.3.0. If you fetch CCCL from GitHub via CPM (or use a conda package of CCCL) you can get a more recent version that will support both CUDA 11 and 12. Currently RAPIDS is using CCCL 2.5.0. |
Related: conda-forge/xgboost-feedstock#167