[jvm-packages] support missing value when constructing dmatrix with iterator #10628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @trivialfis, Could you help review it and merge it? |
|
Hi @hcho3, could you please help review it and merge it. thx very much |
trivialfis
reviewed
Jul 23, 2024
| * The margin must have the same number of elements as the number of | ||
| * rows in this matrix. | ||
| */ | ||
| public void setBaseMargin(float[] baseMargin) throws XGBoostError { |
There was a problem hiding this comment.
Base margin can be a matrix for multi-class classification.
There was a problem hiding this comment.
Yeah, That's true. the issue should have been there for days. This PR didn't mean to try to fix it. so let's just keep it here
trivialfis
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.