Add Dart booster. #1220
Add Dart booster. #1220
Conversation
| @@ -313,8 +352,9 @@ class GBTree : public GradientBooster { | |||
| } | |||
| } | |||
| // commit new trees all at once | |||
| inline void CommitModel(std::vector<std::unique_ptr<RegTree> >&& new_trees, | |||
| int bst_group) { | |||
| inline virtual void | |||
There was a problem hiding this comment.
remove inline, inline and virtual are conflicting with each other
|
@marugari Thanks for the updates. You donot need to open another PR normally, simply update the contents in your branch will update this PR I have made a few more comments. Please also fix the lint error as indicated in https://travis-ci.org/dmlc/xgboost/jobs/132091950 You can reproduce the style check locally by typing make lint |
|
Any updates on this ? |
marugari
force-pushed
the
prototype_dart
branch
7 times, most recently
from
da6b5c4
to
a99b7e8
Compare
|
Update. |
| - type of sampling algorithm. | ||
| - "uniform": dropped trees are selected uniformly. | ||
| - "weighted": dropped trees are selected in proportion to weight. | ||
| * normalize_type [default=0] |
|
I fixed it. |
|
One last thing. The name original gbtree and learning rate for normalize
|
|
In the paper, the authors propose a normalize type. ("original" in my implementation) I will consider appropriate names. |
|
Does that mean we should automatically choosing the current "learning_rate" by default? |
|
If My calculation is correct, we should choose "learning_rate" as normalize type. |
|
Let us directly remove normalize type for now, and go with your implementation by default then :) |
|
please make the update and i will merge the changes in |
|
Thanks this is merged! |
|
@marugari Thanks for the great job of bringing in the DART trainer. To make it more well known and widely accessible to users, I would like to invite you to write a markdown guest blogpost introducing what DART is and how you can use it in xgboost with a few code examples. We can post it on the DMLC website as well documents of XGBoost. Please let me know how you think about it and let me know if you need help in reviewing it. You can first create a PR to https://github.com/dmlc/xgboost/tree/master/doc/tutorials |
|
Thank you for your great support. I'm writing a Japanese blog post. Documents will be submitted afterward. |
|
I found my mistakes. I apologize for the trouble. |
|
no problem, please feel free to open a pr to update the code |
|
@marugari Any updates on possible guest blogpost? |
#1199