Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix Windows tests #4403

Merged
merged 2 commits into from
Apr 26, 2019
Merged

[CI] Fix Windows tests #4403

merged 2 commits into from
Apr 26, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Apr 25, 2019 •
edited
Loading

  • Windows R tests try to compile igraph package from source and fails. Try to install binary igraph instead.
  • Include Graphviz in PATH

@CodingCat

@hcho3 hcho3 changed the title [CI] Fix Windows R tests [CI] Fix Windows tests Apr 26, 2019
@hcho3
Copy link
Collaborator Author

hcho3 commented Apr 26, 2019

@RAMitchell Still trying to sort out failures in AppVeyor

@hcho3
Copy link
Collaborator Author

hcho3 commented Apr 26, 2019

@RAMitchell @CodingCat @trivialfis I'm doing fixing Windows tests. Can you approve?

@CodingCat CodingCat merged commit 503cc42 into dmlc:master Apr 26, 2019
@CodingCat
Copy link
Member

done, thanks!

@hcho3 hcho3 deleted the fix_win_igraph branch April 26, 2019 03:26
@hcho3 hcho3 mentioned this pull request Apr 27, 2019
Merged
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RAMitchell RAMitchell Awaiting requested review from RAMitchell

@CodingCat CodingCat Awaiting requested review from CodingCat

@trivialfis trivialfis Awaiting requested review from trivialfis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @CodingCat