-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- ranking metric acceleration on the gpu #5398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5398 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 11 11
Lines 2411 2411
=======================================
Hits 2027 2027
Misses 384 384 Continue to review full report at Codecov.
|
- this will *significantly* help train non ranking datasets that uses the auc metric (which i hear is quite popular!) - i'll post the perf. numbers shortly
auc metric performance numberstest environment
test
results
|
This reverts commit a38e7bd.
This reverts commit 6a85632.
@trivialfis i would appreciate your review when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for the long wait. Previously I mentioned with @RAMitchell that maybe simple functions are more suitable for implementing the GPU metrics as I think the registry is just too tricky and unnecessary. But I won't block the PR for this as we can refactor them later when needed (like implementing other metrics).
…eve memory pressure
this is the last part of #5326 that has been split. the performance numbers are here
please note the following:
map
,ndcg
,pre
auc[pr]
) applicable to ranking and non-ranking datasets work thusly:@RAMitchell @trivialfis - please review.