Deprecate LabelEncoder in XGBClassifier; Enable cuDF/cuPy inputs in XGBClassifier #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
trivialfis
reviewed
Oct 22, 2020
There was a problem hiding this comment.
Approve to the general idea. See minor comment.
Also please track it in #3986 .
RAMitchell
approved these changes
Oct 23, 2020
|
Could someone explain why we made the deprecation decision for label encoder? I think most native sklearn classifiers do the label transformation internally and call inverse_transform at predict. This causes discrepancy between the xgboost sklearn interface and other sklearn classifiers. |
|
This was to accept cudf and cuPy arrays as X. |
|
Also to avoid saving the scikit learn object in xgboost model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6232
cc @pseudotensor