Support shared library in system path. #6362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt on #6292 . Differences:
sysconfig.get_config_var('LIBDIR')
in Patch libpath.py to be compatible with FreeBSD #6292 is not used here as I thinksys.prefix + 'lib'
should be sufficient although I haven't tested it on freebsd.sys.prefix
can be altered byvirtualenv
whilesysconfig
is invariant.setup.py
is changed to omit building or copyinglibxgboost.so
when the user option--use-system-libxgboost
is specified. So the Python package will not contain a redundant shared object. Combined with the ordering of candidate paths infind_lib
, correctlibxgboost.so
should be loaded.Closes #6291
Closes #5705