Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Implement new save_raw in R. #7571

Merged
merged 1 commit into from
Jan 22, 2022
Merged

[R] Implement new save_raw in R. #7571

merged 1 commit into from
Jan 22, 2022

Conversation

trivialfis
Copy link
Member

From #7545 .

@trivialfis trivialfis changed the title [R] Implement new save raw in R. [R] Implement new save_raw in R. Jan 15, 2022
@trivialfis
Copy link
Member Author

@hetong007 Could you please help take a look?

@trivialfis trivialfis mentioned this pull request Jan 16, 2022
Closed
@trivialfis
Copy link
Member Author

Friendly ping @hetong007 .

hetong007
hetong007 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@hetong007 hetong007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was OOTO thus not reading emails. LGTM!

@hetong007 hetong007 merged commit d262503 into dmlc:master Jan 22, 2022
@trivialfis trivialfis deleted the ubjson-r branch January 22, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetong007 hetong007 hetong007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hetong007