Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Type Hints for Python Package #7742

Merged
merged 26 commits into from
May 17, 2022
Merged

Add Type Hints for Python Package #7742

merged 26 commits into from
May 17, 2022

Commits on May 14, 2022

  1. fix mypy on compat

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    1b2542c View commit details
    Browse the repository at this point in the history

  2. fix imports

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    a4f2594 View commit details
    Browse the repository at this point in the history

  3. add type hints for data.py

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    0498212 View commit details
    Browse the repository at this point in the history

  4. use Sequence for features and FloatCompatible instead of float

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b519d1f View commit details
    Browse the repository at this point in the history

  5. unify FeatureTypes, fix lint

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    738922e View commit details
    Browse the repository at this point in the history

  6. fix mypy on feature_names

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b8d22bb View commit details
    Browse the repository at this point in the history

  7. use cast to narrow type

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    f811b94 View commit details
    Browse the repository at this point in the history

  8. correct signature for maybe_np_slice

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    d948895 View commit details
    Browse the repository at this point in the history

  9. add typing for config.py

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    73d9047 View commit details
    Browse the repository at this point in the history

  10. add tentative typing for callback.py

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    5581895 View commit details
    Browse the repository at this point in the history

  11. add typing for plotting.py

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    55683ce View commit details
    Browse the repository at this point in the history

  12. revert change to attr

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    a0e0954 View commit details
    Browse the repository at this point in the history

  13. use Any for _Model (for now)

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    1bdcb72 View commit details
    Browse the repository at this point in the history

  14. add typing for training.py (partial)

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b55739a View commit details
    Browse the repository at this point in the history

  15. fix linting

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    a3df90b View commit details
    Browse the repository at this point in the history

  16. use optional feature info

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    ead62d3 View commit details
    Browse the repository at this point in the history

  17. add ParamType, FPreProcCallable, fix mypy for training.py

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    aa17117 View commit details
    Browse the repository at this point in the history

  18. fix linting

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    591f875 View commit details
    Browse the repository at this point in the history

  19. revert renaming

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    7a3930a View commit details
    Browse the repository at this point in the history

  20. resolve conflicts

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    76df7d2 View commit details
    Browse the repository at this point in the history

  21. apply review feedback

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    597bc7d View commit details
    Browse the repository at this point in the history

  22. use cast to narrow down

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b5748e2 View commit details
    Browse the repository at this point in the history

  23. remove an unnecessary annotation

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    cb763a7 View commit details
    Browse the repository at this point in the history

  24. remove unused import

    Chengyang Gu committed May 14, 2022
    Configuration menu
    Copy the full SHA
    f2d7887 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Use feature names.

    @trivialfis
    trivialfis committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6aaf2c6 View commit details
    Browse the repository at this point in the history

  2. Take the chance to format the code.

    @trivialfis
    trivialfis committed May 17, 2022
    Configuration menu
    Copy the full SHA
    6b0b371 View commit details
    Browse the repository at this point in the history