Prepare for improving Windows networking compatibility. #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include dmlc filesystem indirectly as dmlc/filesystem.h includes windows.h, which conflicts with winsock2.h * Define `NOMINMAX` conditionally. * Link the winsock library when mysys32 is used. * Add config file for read the doc.
hcho3
requested changes
Sep 8, 2022
tests/cpp/filesystem.h
Outdated
| /*! | ||
| * Copyright (c) 2022 by XGBoost Contributors | ||
| */ | ||
| #pragma once |
There was a problem hiding this comment.
Please use include guard macros instead. CPPLint requires it.
There was a problem hiding this comment.
Changed to using macro guard.
Thank you! I'm not sure about the effect of that as I don't quite understand the internal of windows.h, so I tried to make this change local to XGBoost since it's only used in unittest. |
|
The error is a problem because we are using unity build on windows CI, so all files are exposed. |
hcho3
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOMINMAXconditionally.Extracted from #8225 .