[pyspark] Add type hint to basic utilities. #8375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbo4958
reviewed
Oct 20, 2022
| """Whether it is Spark local mode""" | ||
| # pylint: disable=protected-access | ||
| return spark_context._jsc.sc().isLocal() | ||
|
|
||
|
|
||
| def _get_gpu_id(task_context) -> int: | ||
| def _get_gpu_id(task_context: BarrierTaskContext) -> int: |
There was a problem hiding this comment.
Can we change it to TaskContext instead of BarrierTaskContext?
There was a problem hiding this comment.
Reverted, getTaskInfos is exclusive to the barrier task context.
There was a problem hiding this comment.
Yeah, only _get_host_ip needs BarrerTaskContext. for others, TaskContext is ok.
There was a problem hiding this comment.
Since get host ip is called by others, unless we want to perform a down cast we need to pass the type down.
This reverts commit 9c626c5.
wbo4958
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.