Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PySpark tests. #8605

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Refactor PySpark tests. #8605

merged 1 commit into from
Jan 4, 2023

Conversation

trivialfis
Copy link
Member

  • Convert classifier tests to pytest tests.
  • Replace hardcoded tests.

Extracted from #8272 .

@trivialfis
Refactor PySpark tests.
58be3ea 
- Convert classifier tests to pytest tests.
- Replace hardcoded tests.
RAMitchell
RAMitchell approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only concern is that the time does not increase dramatically.

@trivialfis
Copy link
Member Author

The test is mostly handcrafted and hence small.

@trivialfis trivialfis merged commit d308124 into dmlc:master Jan 4, 2023
@trivialfis trivialfis deleted the pyspark-clf-tests branch January 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell