Initial support for column-split cpu predictor #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging the master branch should fix the CI error. |
trivialfis
reviewed
Jan 15, 2023
| if (prev_thread_temp_size < nthread) { | ||
| out->resize(nthread, RegTree::FVec()); | ||
| // init thread buffers | ||
| static void InitThreadTemp(int nthread, std::vector<RegTree::FVec> *out) { |
There was a problem hiding this comment.
Use an anonymous namespace instead of static if it's not intended to be used outside of the TU.
src/predictor/cpu_predictor.cc
Outdated
|
|
||
| CHECK_EQ(model_.param.size_leaf_vector, 0) << "size_leaf_vector is enforced to 0 so far"; | ||
| // parallel over local batch | ||
| const auto nsize = static_cast<bst_omp_uint>(batch.Size()); |
There was a problem hiding this comment.
No need to set bst_omp... explicitly, use auto and ParallelFor will do the casting:
common::Parallel(n_blocks, n_threads, [&](auto block_id) {}); // auto block_id has the same type as `n_blocks`.| std::vector<RegTree::FVec> feat_vecs_{}; | ||
|
|
||
| std::size_t n_rows_; | ||
| std::vector<BitVector::value_type> decision_storage_{}; |
There was a problem hiding this comment.
Could you please add some comments about the layout of the storage? How to index it?
trivialfis
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data is split by column, produce predictions in two passes by leveraging bit vectors.
Part of #8424