Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in-memory communicator to test quantile #8710

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jan 25, 2023

The in-memory communicator can run allreduce calls in process, thus making it easier to test distributed quantile sketches. We no longer need to rely on python or dask.

@trivialfis @hcho3

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up the tests! Could you please help remove the marker in tests/pytest.ini?

@rongou
Copy link
Contributor Author

rongou commented Jan 26, 2023

Done.

} else {
LOG(WARNING) << msg;
LOG(WARNING) << "Skipping Quantile SameOnAllWorkers test";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Removed.

@trivialfis trivialfis merged commit 8af98e3 into dmlc:master Jan 27, 2023
@trivialfis
Copy link
Member

@rongou Hi, I'm running into an error when testing the c++ code on a 2-GPU machine:

[ RUN      ] GPUQuantile.AllReduceBasic
terminate called after throwing an instance of 'dmlc::Error'
  what():  [17:36:08] /home/jiamingy/Workspace/XGBoost/xgboost/src/collective/nccl_device_communicator.cuh:49: Check failed: n_uniques == world (1 vs. 2) : Multiple processes within communication group running on same CUDA device is not supported. c8be5176b263d057236621713f361bc8

Stack trace:
  [bt] (0) ./testxgboost(dmlc::LogMessageFatal::~LogMessageFatal()+0x7e) [0x55c0b3375b5e]
  [bt] (1) ./testxgboost(xgboost::collective::NcclDeviceCommunicator::NcclDeviceCommunicator(int, xgboost::collective::Communicator*)+0x78e) [0x55c0b36e2dee]

Any chance you can take a look when you are available?

@rongou
Copy link
Contributor Author

rongou commented Feb 9, 2023

OK, let me see if I can reproduce it.

@rongou rongou deleted the test-quantile-in-memory branch September 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants