-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use in-memory communicator to test quantile #8710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning up the tests! Could you please help remove the marker in tests/pytest.ini
?
Done. |
tests/cpp/common/test_quantile.cc
Outdated
} else { | ||
LOG(WARNING) << msg; | ||
LOG(WARNING) << "Skipping Quantile SameOnAllWorkers test"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. Removed.
@rongou Hi, I'm running into an error when testing the c++ code on a 2-GPU machine:
Any chance you can take a look when you are available? |
OK, let me see if I can reproduce it. |
The in-memory communicator can run allreduce calls in process, thus making it easier to test distributed quantile sketches. We no longer need to rely on python or dask.
@trivialfis @hcho3