[spark] Make spark model have the same UID with its estimator #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weichen Xu <[email protected]>
|
CC @wbo4958 @trivialfis Would you mind taking a look ? Thank you! |
|
Can we backport this fix to xgboost 1.7.6 version ? |
|
I don't have any plan for 1.7.6 at the moment, is this fix significant? In what scenario this can cause issues? |
Only some very edge case (a pyspark pipeline contains xgboost estimator, and crossvalidator tunes the pipeline, and we tunes some params related to xgboost model prediction). It is not an critical bug so 1.7.6 release is not urgent for . :) |
|
@trivialfis Could you trigger all CI runs and then merge the PR once CI passed? Thankyou! |
|
Reminder: Backport this commit to 1.7 branch :) |
trivialfis
approved these changes
Apr 13, 2023
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Jun 9, 2023
…tor (dmlc#9022) Signed-off-by: Weichen Xu <[email protected]>
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Jun 10, 2023
…tor (dmlc#9022) Signed-off-by: Weichen Xu <[email protected]>
trivialfis
added a commit
that referenced
this pull request
Jun 11, 2023
…tor (#9022) (#9285) Signed-off-by: Weichen Xu <[email protected]> Co-authored-by: WeichenXu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make spark model have the same UID with its estimator.
Because all other pyspark models obey the rule that uses the same UID with estimator, and the UID is used in param copying (e.g. CrossValidator copies param list to estimator, and UID is used for param owner validation), so we need to make the UID correct.