More refactoring to take advantage of collective aggregators #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Apr 25, 2023
| void ApplyWithLabels(MetaInfo const& info, T* buffer, size_t size, Function&& function, | ||
| Args&&... args) { | ||
| template <typename Function> | ||
| void ApplyWithLabels(MetaInfo const& info, void* buffer, size_t size, Function&& function) { |
There was a problem hiding this comment.
Is type erasion necessary? (void*)
There was a problem hiding this comment.
When doing the broadcast, we don't need to know the type, only the size (https://github.com/dmlc/xgboost/blob/master/src/collective/communicator-inl.h#L128), so in here we don't really care about the type either.
|
@trivialfis @hcho3 Any ideas about the R test errors? Doesn't seem to be related to this PR. |
trivialfis
approved these changes
Apr 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
ShouldHaveLabels()to encode when we expect to have labels.