-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bitwise allreduce in NCCL communicator #9300
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3954028
Support bitwise allreduce in NCCL communicator
rongou 978d506
use launchn instead of thrust transform
rongou abeade4
support nccl off
rongou 4cc5e71
fix cpplint error
rongou f891ed7
Merge remote-tracking branch 'upstream/master' into bitwise-allreduce
rongou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,228 @@ | ||
/*! | ||
* Copyright 2023 XGBoost contributors | ||
*/ | ||
#if defined(XGBOOST_USE_NCCL) | ||
#include "nccl_device_communicator.cuh" | ||
|
||
namespace xgboost { | ||
namespace collective { | ||
|
||
NcclDeviceCommunicator::NcclDeviceCommunicator(int device_ordinal, Communicator *communicator) | ||
: device_ordinal_{device_ordinal}, communicator_{communicator} { | ||
if (device_ordinal_ < 0) { | ||
LOG(FATAL) << "Invalid device ordinal: " << device_ordinal_; | ||
} | ||
if (communicator_ == nullptr) { | ||
LOG(FATAL) << "Communicator cannot be null."; | ||
} | ||
|
||
int32_t const rank = communicator_->GetRank(); | ||
int32_t const world = communicator_->GetWorldSize(); | ||
|
||
if (world == 1) { | ||
return; | ||
} | ||
|
||
std::vector<uint64_t> uuids(world * kUuidLength, 0); | ||
auto s_uuid = xgboost::common::Span<uint64_t>{uuids.data(), uuids.size()}; | ||
auto s_this_uuid = s_uuid.subspan(rank * kUuidLength, kUuidLength); | ||
GetCudaUUID(s_this_uuid); | ||
|
||
// TODO(rongou): replace this with allgather. | ||
communicator_->AllReduce(uuids.data(), uuids.size(), DataType::kUInt64, Operation::kSum); | ||
|
||
std::vector<xgboost::common::Span<uint64_t, kUuidLength>> converted(world); | ||
size_t j = 0; | ||
for (size_t i = 0; i < uuids.size(); i += kUuidLength) { | ||
converted[j] = xgboost::common::Span<uint64_t, kUuidLength>{uuids.data() + i, kUuidLength}; | ||
j++; | ||
} | ||
|
||
auto iter = std::unique(converted.begin(), converted.end()); | ||
auto n_uniques = std::distance(converted.begin(), iter); | ||
|
||
CHECK_EQ(n_uniques, world) | ||
<< "Multiple processes within communication group running on same CUDA " | ||
<< "device is not supported. " << PrintUUID(s_this_uuid) << "\n"; | ||
|
||
nccl_unique_id_ = GetUniqueId(); | ||
dh::safe_cuda(cudaSetDevice(device_ordinal_)); | ||
dh::safe_nccl(ncclCommInitRank(&nccl_comm_, world, nccl_unique_id_, rank)); | ||
dh::safe_cuda(cudaStreamCreate(&cuda_stream_)); | ||
} | ||
|
||
NcclDeviceCommunicator::~NcclDeviceCommunicator() { | ||
if (communicator_->GetWorldSize() == 1) { | ||
return; | ||
} | ||
if (cuda_stream_) { | ||
dh::safe_cuda(cudaStreamDestroy(cuda_stream_)); | ||
} | ||
if (nccl_comm_) { | ||
dh::safe_nccl(ncclCommDestroy(nccl_comm_)); | ||
} | ||
if (xgboost::ConsoleLogger::ShouldLog(xgboost::ConsoleLogger::LV::kDebug)) { | ||
LOG(CONSOLE) << "======== NCCL Statistics========"; | ||
LOG(CONSOLE) << "AllReduce calls: " << allreduce_calls_; | ||
LOG(CONSOLE) << "AllReduce total MiB communicated: " << allreduce_bytes_ / 1048576; | ||
} | ||
} | ||
|
||
namespace { | ||
ncclDataType_t GetNcclDataType(DataType const &data_type) { | ||
ncclDataType_t result; | ||
switch (data_type) { | ||
case DataType::kInt8: | ||
result = ncclInt8; | ||
break; | ||
case DataType::kUInt8: | ||
result = ncclUint8; | ||
break; | ||
case DataType::kInt32: | ||
result = ncclInt32; | ||
break; | ||
case DataType::kUInt32: | ||
result = ncclUint32; | ||
break; | ||
case DataType::kInt64: | ||
result = ncclInt64; | ||
break; | ||
case DataType::kUInt64: | ||
result = ncclUint64; | ||
break; | ||
case DataType::kFloat: | ||
result = ncclFloat; | ||
break; | ||
case DataType::kDouble: | ||
result = ncclDouble; | ||
break; | ||
default: | ||
LOG(FATAL) << "Unknown data type."; | ||
} | ||
return result; | ||
} | ||
|
||
bool IsBitwiseOp(Operation const &op) { | ||
return op == Operation::kBitwiseAND || op == Operation::kBitwiseOR || | ||
op == Operation::kBitwiseXOR; | ||
} | ||
|
||
ncclRedOp_t GetNcclRedOp(Operation const &op) { | ||
ncclRedOp_t result; | ||
switch (op) { | ||
case Operation::kMax: | ||
result = ncclMax; | ||
break; | ||
case Operation::kMin: | ||
result = ncclMin; | ||
break; | ||
case Operation::kSum: | ||
result = ncclSum; | ||
break; | ||
default: | ||
LOG(FATAL) << "Unsupported reduce operation."; | ||
} | ||
return result; | ||
} | ||
|
||
template <typename Func> | ||
void RunBitwiseAllreduce(char *out_buffer, char const *device_buffer, Func func, int world_size, | ||
std::size_t size, cudaStream_t stream) { | ||
dh::LaunchN(size, stream, [=] __device__(std::size_t idx) { | ||
out_buffer[idx] = device_buffer[idx]; | ||
for (auto rank = 1; rank < world_size; rank++) { | ||
out_buffer[idx] = func(out_buffer[idx], device_buffer[rank * size + idx]); | ||
} | ||
}); | ||
} | ||
} // anonymous namespace | ||
|
||
void NcclDeviceCommunicator::BitwiseAllReduce(void *send_receive_buffer, std::size_t count, | ||
DataType data_type, Operation op) { | ||
auto const world_size = communicator_->GetWorldSize(); | ||
auto const size = count * GetTypeSize(data_type); | ||
dh::caching_device_vector<char> buffer(size * world_size); | ||
auto *device_buffer = buffer.data().get(); | ||
|
||
// First gather data from all the workers. | ||
dh::safe_nccl(ncclAllGather(send_receive_buffer, device_buffer, count, GetNcclDataType(data_type), | ||
nccl_comm_, cuda_stream_)); | ||
|
||
// Then reduce locally. | ||
auto *out_buffer = static_cast<char *>(send_receive_buffer); | ||
switch (op) { | ||
case Operation::kBitwiseAND: | ||
RunBitwiseAllreduce(out_buffer, device_buffer, thrust::bit_and<char>(), world_size, size, | ||
cuda_stream_); | ||
break; | ||
case Operation::kBitwiseOR: | ||
RunBitwiseAllreduce(out_buffer, device_buffer, thrust::bit_or<char>(), world_size, size, | ||
cuda_stream_); | ||
break; | ||
case Operation::kBitwiseXOR: | ||
RunBitwiseAllreduce(out_buffer, device_buffer, thrust::bit_xor<char>(), world_size, size, | ||
cuda_stream_); | ||
break; | ||
default: | ||
LOG(FATAL) << "Not a bitwise reduce operation."; | ||
} | ||
} | ||
|
||
void NcclDeviceCommunicator::AllReduce(void *send_receive_buffer, std::size_t count, | ||
DataType data_type, Operation op) { | ||
if (communicator_->GetWorldSize() == 1) { | ||
return; | ||
} | ||
|
||
dh::safe_cuda(cudaSetDevice(device_ordinal_)); | ||
if (IsBitwiseOp(op)) { | ||
BitwiseAllReduce(send_receive_buffer, count, data_type, op); | ||
} else { | ||
dh::safe_nccl(ncclAllReduce(send_receive_buffer, send_receive_buffer, count, | ||
GetNcclDataType(data_type), GetNcclRedOp(op), nccl_comm_, | ||
cuda_stream_)); | ||
} | ||
allreduce_bytes_ += count * GetTypeSize(data_type); | ||
allreduce_calls_ += 1; | ||
} | ||
|
||
void NcclDeviceCommunicator::AllGatherV(void const *send_buffer, size_t length_bytes, | ||
std::vector<std::size_t> *segments, | ||
dh::caching_device_vector<char> *receive_buffer) { | ||
if (communicator_->GetWorldSize() == 1) { | ||
return; | ||
} | ||
|
||
dh::safe_cuda(cudaSetDevice(device_ordinal_)); | ||
int const world_size = communicator_->GetWorldSize(); | ||
int const rank = communicator_->GetRank(); | ||
|
||
segments->clear(); | ||
segments->resize(world_size, 0); | ||
segments->at(rank) = length_bytes; | ||
communicator_->AllReduce(segments->data(), segments->size(), DataType::kUInt64, Operation::kMax); | ||
auto total_bytes = std::accumulate(segments->cbegin(), segments->cend(), 0UL); | ||
receive_buffer->resize(total_bytes); | ||
|
||
size_t offset = 0; | ||
dh::safe_nccl(ncclGroupStart()); | ||
for (int32_t i = 0; i < world_size; ++i) { | ||
size_t as_bytes = segments->at(i); | ||
dh::safe_nccl(ncclBroadcast(send_buffer, receive_buffer->data().get() + offset, as_bytes, | ||
ncclChar, i, nccl_comm_, cuda_stream_)); | ||
offset += as_bytes; | ||
} | ||
dh::safe_nccl(ncclGroupEnd()); | ||
} | ||
|
||
void NcclDeviceCommunicator::Synchronize() { | ||
if (communicator_->GetWorldSize() == 1) { | ||
return; | ||
} | ||
dh::safe_cuda(cudaSetDevice(device_ordinal_)); | ||
dh::safe_cuda(cudaStreamSynchronize(cuda_stream_)); | ||
} | ||
|
||
} // namespace collective | ||
} // namespace xgboost | ||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a side note, there's
dh::CUDAStream
, which is a RAII version of async stream.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to it.