Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry switching to per-thread default stream #9416

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jul 25, 2023

Added a cmake option to turn it off if something goes wrong. Fixed the failing mgpu pytests caused by thread safety issues with cub::CachingDeviceAllocator.

@rongou
Copy link
Contributor Author

rongou commented Jul 25, 2023

@trivialfis @hcho3

@trivialfis trivialfis merged commit 7579905 into dmlc:master Jul 25, 2023
21 checks passed
@trivialfis
Copy link
Member

Nice fix!

jinmfeng001 pushed a commit to jinmfeng001/xgboost that referenced this pull request Jul 26, 2023
@rongou rongou deleted the per-thread-default-stream branch September 25, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants