Fix GPU categorical split memory allocation. #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Aug 28, 2023
| @@ -64,20 +64,13 @@ struct DeviceSplitCandidate { | |||
| // split. | |||
| bst_cat_t thresh{-1}; | |||
|
|
|||
| common::CatBitField split_cats; | |||
There was a problem hiding this comment.
Trying to understand what this PR does.
Does the reference split_cats get invalidated as more categories are added? Why is it better to get the categories from the evaluator directly?
There was a problem hiding this comment.
Correct. It's invalidated when more nodes are added.
There was a problem hiding this comment.
So same reason as why you shouldn't carry around references to vector elements? Got it.
There was a problem hiding this comment.
I think it was introduced during optimization and refactoring in 1.7. But should be fixed now. I will do some more tests myself. The error was only reproducible using a sanitizer.
hcho3
approved these changes
Aug 28, 2023
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Aug 29, 2023
trivialfis
added a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9521 .
split_catsfrom split candidate.