Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU support to NVFlare vertical demo #9552

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Sep 5, 2023

No description provided.

@rongou
Copy link
Contributor Author

rongou commented Sep 5, 2023

@trivialfis @SYangster

@trivialfis trivialfis merged commit 0f35493 into dmlc:master Sep 6, 2023
21 checks passed
Comment on lines 85 to +86
if self._use_gpus:
self.log_info(fl_ctx, 'GPUs are not currently supported by vertical federated XGBoost')
if self._use_gpus:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this condition duplicate? @rongou

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. Copy paste error. Sent #9578

@rongou rongou deleted the nvflare-demo-gpu branch September 25, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants