More support for column split in gpu predictor #9562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rongou
commented
Sep 8, 2023
rongou
commented
- Added support for predict leaf
- More testing
|
@trivialfis I think this is finally working now. Please take a look. Thanks! |
trivialfis
reviewed
Sep 13, 2023
| d_out_predictions[out_prediction_idx] += GetLeafWeightByBitVector( | ||
| row_idx, d_tree, decision_bits, missing_bits, num_nodes, tree_offset); | ||
| tree_offset += d_tree.d_tree.size(); | ||
| if (num_group == 1) { |
There was a problem hiding this comment.
Is it necessary to distinguish whether n_groups is 1? I think the indexing should be similar if not the same right?
num_row * 1 + 0 # only one group
There was a problem hiding this comment.
This is based on the original PredictKernel (line 299). I guess it's just a performance optimization to reduce global memory access to d_out_predictions?
trivialfis
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.