[breaking] [jvm-packages] Remove rabit check point. #9599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `numBoostedRound` to jvm packages - Remove rabit checkpoint version. [breaking] - Change the starting version of training continuation in JVM [breaking]. The last item is a bit more subtle, the change aligns JVM packages with Python packages. After this PR, the second training phrase counts iteration from 0 instead of from the previous starting iteration.
trivialfis
force-pushed
the
rabit-remove-chpt
branch
from
bccf531
to
aac597a
Compare
|
@wbo4958 Could you please help review this when you are available? |
wbo4958
reviewed
Sep 25, 2023
| } | ||
|
|
||
| public void setVersion(int version) { | ||
| this.version = version; |
There was a problem hiding this comment.
seems still need to remove the definition of version
There was a problem hiding this comment.
Not sure what would it do to binary serialization.
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/ExternalCheckpointManager.java
Outdated
Show resolved
Hide resolved
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/ExternalCheckpointManager.java
Outdated
Show resolved
Hide resolved
| booster.saveRabitCheckpoint(); | ||
| } | ||
| for (int iter = 0; iter < numRounds; iter++) { | ||
| booster.update(dtrain, iter); |
There was a problem hiding this comment.
the original logic is
if (obj != null) {
booster.update(dtrain, obj);
} else {
booster.update(dtrain, iter);
}please double check
There was a problem hiding this comment.
Fixed. Need to create a test for the objective in a different PR.
|
GLTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numBoostedRoundto jvm packagesThe last item is a bit more subtle, the change aligns JVM packages with Python packages. After this PR, training continuation counts iteration from 0 instead of from the previous starting iteration. The checkpointing scheme is changed to use boosting versions. I don't understand the previous versioning scheme, likely a legacy inherited from rabit.