Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sys.base_prefix instead of sys.prefix #9711

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Use sys.base_prefix instead of sys.prefix #9711

merged 2 commits into from
Oct 24, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Oct 24, 2023 •
edited
Loading

Follow-up to #9687.

#9687 should have used sys.base_prefix instead of sys.prefix, as in #9349. This is the cause of a CI failure: https://github.com/dmlc/xgboost/actions/runs/6622306062/job/17988733477

@hcho3 hcho3 mentioned this pull request Oct 24, 2023
Closed
@hcho3 hcho3 merged commit a408254 into dmlc:release_2.0.0 Oct 24, 2023
16 of 25 checks passed
@hcho3 hcho3 deleted the fix_libpath branch October 24, 2023 06:31
hcho3 added a commit to hcho3/xgboost that referenced this pull request Oct 24, 2023
@hcho3
Use sys.base_prefix instead of sys.prefix (dmlc#9711)
4c658ab 
* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too
@hcho3 hcho3 mentioned this pull request Oct 24, 2023
Merged
hcho3 added a commit that referenced this pull request Oct 25, 2023
@hcho3
Fix libpath logic for Windows (#9712)
01d59de 
* Fix libpath logic for Windows (#9687)

* Use sys.base_prefix instead of sys.prefix (#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge 2.0.1 patch (#7)
89ddb4c 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge xgboost 2.0.1 patch (#9)
ad03395 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin pushed a commit to IntelPython/xgboost_oneapi that referenced this pull request Oct 26, 2023
@hcho3 @razdoburdin
Use sys.base_prefix instead of sys.prefix (dmlc#9711)
d3772fb 
* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too
razdoburdin added a commit to razdoburdin/xgboost that referenced this pull request Oct 26, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Merge xgboost 2.0.1 patch (#9)
eafbdb6 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
razdoburdin pushed a commit to razdoburdin/xgboost that referenced this pull request Oct 26, 2023
@hcho3 @razdoburdin
Use sys.base_prefix instead of sys.prefix (dmlc#9711)
db84f88 
* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Nov 23, 2023
@razdoburdin @trivialfis
@hcho3 @wbo4958
Adopt Patch 2.0.2 (#22)
174492b 
* [backport] Support pandas 2.1.0. (dmlc#9557) (dmlc#9655)

* [backport] Add support for cgroupv2. (dmlc#9651) (dmlc#9656)

* Bump version to 2.0.1. (dmlc#9660)

* [backport] [CI] Pull CentOS 7 images from NGC (dmlc#9666) (dmlc#9668)

* Fix build for GCC 8.x (dmlc#9670)

* [backport][pyspark] Support stage-level scheduling (dmlc#9519) (dmlc#9686)

Co-authored-by: Bobby Wang <[email protected]>

* Fix build for AppleClang 11 (dmlc#9684)

* Fix libpath logic for Windows (dmlc#9687)

* [CI] Build libxgboost4j.dylib for Intel Mac (dmlc#9704)

* [jvm-packages] Remove hard dependency on libjvm (dmlc#9698) (dmlc#9705)

* Use sys.base_prefix instead of sys.prefix (dmlc#9711)

* Use sys.base_prefix instead of sys.prefix

* Update libpath.py too

* [backport] Fix using categorical data with the ranker. (dmlc#9753) (dmlc#9778)

* [jvm-packages] Add Scala version suffix to xgboost-jvm package (dmlc#9776)

* Update JVM script (dmlc#9714)

* Bump version to 2.0.2; revamp pom.xml

* Update instructions in prepare_jvm_release.py

* Fix formatting

* fix merging for R-package/configure

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Co-authored-by: Bobby Wang <[email protected]>
Co-authored-by: Dmitry Razdoburdin <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis