Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Fix POM for xgboost-jvm metapackage #9893

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Dec 14, 2023

Ref: #9787 #9797

Maven cannot expand the variable ${scala.binary.version} in the module name.

Also update dev/prepare_jvm_release.py:

  • The script can now run on any machine, since all native libraries will be downloaded from the CI pipeline.
  • To upload packages targeting Scala 2.13, the maintainer needs to use dev/change_scala_version.py to replace all occurrences of xgboost-jvm_2.12 with xgboost-jvm_2.13.

@trivialfis
Copy link
Member

Do we need (part of) it in the master branch?

@hcho3
Copy link
Collaborator Author

hcho3 commented Dec 14, 2023

Yes, I will port it to the master branch.

@wbo4958
Copy link
Contributor

wbo4958 commented Dec 14, 2023

To upload packages targeting Scala 2.13, the maintainer needs to use sed to replace all occurrences of xgboost-jvm_2.12 with xgboost-jvm_2.13.

Could you also create a script to it, you can refer to https://github.com/apache/spark/blob/master/dev/change-scala-version.sh

@hcho3 hcho3 merged commit 3acbd86 into dmlc:release_2.0.0 Dec 15, 2023
19 of 26 checks passed
@hcho3 hcho3 deleted the fix_jvm_pom branch December 15, 2023 00:50
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Dec 19, 2023
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880)

* [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879)

* [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887)

* [CI] Set up CI for Mac M1 (dmlc#9699)

* [CI] Improve CI for Mac M1 (dmlc#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886)

* [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Bump version to 2.0.3 (dmlc#9895)

* Update change_scala_version.py to also change scala.version property (dmlc#9897)

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
hcho3 added a commit to hcho3/xgboost that referenced this pull request Jan 11, 2024
* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version
hcho3 added a commit to hcho3/xgboost that referenced this pull request Jan 11, 2024
* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version
hcho3 added a commit that referenced this pull request Jan 12, 2024
* [jvm-packages] Add Scala version suffix to xgboost-jvm package (#9776)

* Update JVM script (#9714)

* Revamp pom.xml

* Update instructions in prepare_jvm_release.py

* Fix formatting

* [jvm-packages] Fix POM for xgboost-jvm metapackage (#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Update change_scala_version.py to also change scala.version property (#9897)

* Remove 'release-cpu-only' profile

* Remove scala-2.13 profile; enable gpu package for Scala 2.13
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request May 15, 2024
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880)

* [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879)

* [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887)

* [CI] Set up CI for Mac M1 (dmlc#9699)

* [CI] Improve CI for Mac M1 (dmlc#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886)

* [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Bump version to 2.0.3 (dmlc#9895)

* Update change_scala_version.py to also change scala.version property (dmlc#9897)

* [backport] Fix compiling with the latest CTX. (dmlc#10263)

---------

Co-authored-by: Jiaming Yuan <[email protected]>
Co-authored-by: Philip Hyunsu Cho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants