Fix gain calculation in multi-target tree. #9978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rongou I think the allgather is not working correctly for vector-leaf, will look into it after replacing the rabit module (still trying to get back to it). |
|
@rongou I have disabled the test for now. We need to refactor the evaluation to serialize the entries before synchronization. |
trivialfis
commented
Jan 16, 2024
| @@ -149,6 +149,9 @@ class MultiTargetHistBuilder { | |||
| } | |||
|
|
|||
| void InitData(DMatrix *p_fmat, RegTree const *p_tree) { | |||
| if (collective::IsDistributed()) { | |||
There was a problem hiding this comment.
@hcho3 Added a check to disable the distributed training.
hcho3
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9960 .