Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in the event loop. #9990

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Fix error handling in the event loop. #9990

merged 6 commits into from
Jan 16, 2024

Conversation

trivialfis
Copy link
Member

Make sure the thread worker cannot exit without the stop_ flag being set.

Close #9856 .

@trivialfis
Copy link
Member Author

cc @rongou

@trivialfis trivialfis merged commit 85d0924 into dmlc:master Jan 16, 2024
28 checks passed
@trivialfis trivialfis deleted the fix-event-loop branch January 16, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Flaky timeout test.
2 participants
@trivialfis @rongou