Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router to v6 #1305

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Conversation

syucream
Copy link
Contributor

@syucream syucream commented Oct 19, 2024

To follow recent updates, and to prepare to upgrade that to v7 (ref. https://zenn.dev/jiiyaaa/articles/a937b4a66a4bb6 )

@syucream syucream marked this pull request as ready for review October 26, 2024 11:23
Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@userlocalhost userlocalhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! Thank you very much for up-to-date this implementation 👍

@userlocalhost userlocalhost merged commit b95b673 into dmm-com:master Oct 28, 2024
3 checks passed
@userlocalhost userlocalhost deleted the fix/react-router-v6 branch October 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants