-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Docs: add an 'install' section to the README? #83
Comments
Uh oh! @jclaveau, the image you shared is missing helpful alt text. Check your issue body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Uh oh! @jclaveau, the image you shared is missing helpful alt text. Check your issue body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Whew, got me scared with this title 😄 but this is really a docs request. I don't recall ever seeing an issue reported on the Furthermore, if you're going to link to a repository, you should really pin to a specific commit. Linking to ...all that being said, most of my other repos have an explicit |
I didn't expect dedent to be added with a Thank you for your time! |
## PR Checklist - [x] Addresses an existing open issue: fixes #83 - [x] That issue was marked as [`status: accepting prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Adds an explicit `npm install dedent` code block to the top of the README.md
🎉 This is included in version v1.5.2 🎉 The release is available on: Cheers! 📦🚀 |
Bug Report Checklist
main
branch of the repository.Expected
Actual
I installed
dedent
withpnpm install dmnd/dedent
Then Typescript can't find the declaration but at runtime (Vite devServer) my strings are dedented:
Also trying to auto-import it with https://github.com/unplugin/unplugin-auto-import configured with
I get
Additional Info
My project is a pnpm monorepo with one tsconfig per package. dedent is a dep of only one of the packages
When I go to
node_modules/dedent
, thedist
folder is missing.When I install the dev dependencies and build it, the
dist
folder is created and everything works wellInvestigating I realized that my package.json was odd
so I run a
pnpm remove dedent
thenpnpm install dedent
and everythin works well now (removing it first is mandatory)I open this bug anyway as it may be useful to add an 'install' section to the README to avoid this. I personally didn't know that pnpm would automatically map to github if I added the vendor in the install command.
The text was updated successfully, but these errors were encountered: