Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add builtin Revise support #36

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

Shuenhoy
Copy link
Contributor

@Shuenhoy Shuenhoy commented Jul 21, 2021

Now, the users only need to use Revise before start the server. No other operation is needed.
DaemonMode has been benefiting my own works a lot, hope this PR could make it more beneficial and practical.

BTW, maybe executing Revise.revise() also regularly instead of executing it only before codes are sent to the server could make the experiences even better, but I do not have much time to verify this idea.

@dmolina
Copy link
Owner

dmolina commented Jul 22, 2021

Thanks you. I have checked and it seems a good solutions. Maybe too many parameters but it is my fault, and I guess it can be refactorized a bit later. Now I am travelling but in a few days I will do a new version with that new functionality.

@dmolina dmolina merged commit a82d943 into dmolina:master Jul 22, 2021
@Shuenhoy Shuenhoy deleted the add_builtin_revise_support branch July 22, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants