MNT Update @methods on class docblocks #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Dec 14, 2023
src/Model/ElementForm.php
Outdated
Comment on lines
13
to
14
| * @method SilverStripe\ORM\HasManyList<EmailRecipient> EmailRecipients() | ||
| * @method SilverStripe\ORM\HasManyList<SubmittedForm> Submissions() |
There was a problem hiding this comment.
These are added through a trait.
I think it's correct for them to appear here (I'm unsure how @method annotations work with trait-to-class... maybe they just go on the trait and don't need to be here too?) - but we need to either import the EmailRecipient and SubmittedForm with use statements, or use the FQCN here.
There was a problem hiding this comment.
Having updated the docblock writer, using the FCQN here
emteknetnz
force-pushed
the
pulls/4.1/docblock
branch
from
2985896
to
d67c982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#163