Address issues in #137 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to issue #137 The expressions to derive the values for 3 BasePagedList properties have been changed to be more appropriate and inline with the others in cases where the current page has no data. HasPreviousPage when PageNumber > PageCount is now false instead of true. IsFirstPage when PageCount = 0 is now false instead of true. FirstItemOnPage and LastItemOnPage when PageCount = 0 or PageNumber > PageCount are now both 0 instead of being calculated based on page number and size. Added test for the totalItemCount parameter in the BasePagedList constructor being less than 0 - this is an error condition. This work reverts commit [9cca40b] (the fix for issue #115 (Empty list causes exception) is now implemented in X.PagedList.PagedListExtensions.ToPagedList) and [35ca2e5]. Unit tests and documentation comments updated accordingly.
Restructured a few unit tests to remove xUnit2000 (The literal or constant value ... should be passed as the 'expected' argument ...), xUnit2004 (Do not use Assert.Equal() to check for boolean conditions) and xUnit2013 (Do not use Assert.Equal() to check for collection size) warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.