Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csproj fixes after merges #272

Merged
merged 3 commits into from
Jul 10, 2024
Merged

csproj fixes after merges #272

merged 3 commits into from
Jul 10, 2024

Conversation

adschmu
Copy link
Contributor

@adschmu adschmu commented Jul 10, 2024

See individual commits. Only tidying up, no functional changes.

  1. Move JetBrains.Annotations from Directory.Build.props to csproj

     Updating this is more complicated inside the props file. Move it back
     to csproj to make updating easier.

  2. Consolidate PropertyGroup in X.PagedList.csproj

  3. Whitespace fixes

  4. Remove icon.png include in X.PagedList.csproj

     This is already in Directory.Build.props
This removes duplicated/redundant lines due to merges.
@adschmu
Copy link
Contributor Author

adschmu commented Jul 10, 2024

That's why I prefer rebase to merging. Merging frequently breaks something if one branch is sufficiently older than the other. ;-)

Update Microsoft.EntityFrameworkCore for all frameworks and restrict maximum
version for net6.0.
@a-gubskiy a-gubskiy merged commit 765702d into dncuug:master Jul 10, 2024
2 checks passed
@adschmu adschmu deleted the pr/csproj2 branch July 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants