Two PagedList improvements #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not really a point to creating a PagedList without a superset. If somebody actually desires to have an empty one, he should provide an empty list. This is a breaking change. If somebody actually created a PagedList with "null" for whatever reason, this will now throw an Exception.
This addresses two aspects:
1. Instead of using AddRange(), just saving the existing List is cheaper.
2. There is an important difference between an Expression and a method
delegate (Func<Tin, Tout>). In almost every case, you will need to
use Expressions with IQueryable and method delegates with IEnumerable.
In the previous implementation, we threw away the Expression by using
Compile(). With a real IQueryable, this would mean that processing is moved
from the DB to client evaluation for anything beyond that point. Hence,
we change this to use the proper OrderBy overload for Expressions now with
IQueryable. When a method delegate is provided, we directly assume
IEnumerable.
Note that this is NO breaking change, since IQueryable implements
IEnumerable. However, for a real IQueryable this will now actually work
on the DB e.g. in an EF Core scenario.
|
Since I've started looking at it, I found the issues with Expression.Compile(). In contrast to most of the other stuff we discussed recently which is somewhat cosmetic, this is a functional issue. |
This was referenced Jul 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes, one is a breaking one (but a reasonable one).