This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
ECS: replace github.com/sanathkr/go-yaml with gopkg.in/yaml.v3
#2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @milas , would you be kind enough to review this PR when you are free? Thanks ❤️ |
|
Hello @milas @StefanScherer @glours @ulyssessouza @nicksieger . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago. I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them. Thank you for your time and consideration. I truly appreciate it. ❤️ |
thyarles
reviewed
Jun 7, 2023
The `github.com/sanathkr/go-yaml` was a fork and it was last updated in 2017. In AWS CloudFormation v7.2.0, they switched their YAML library to `gopkg.in/yaml.v3` [1]. [1]: awslabs/goformation#535 Signed-off-by: Eng Zer Jun <[email protected]>
|
This PR doesn't get any attention and this repository is retiring in November 2023. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently we are using two YAML libraries:
github.com/sanathkr/go-yaml v0.0.0-20170819195128-ed9d249f429bgopkg.in/yaml.v3 v3.0.1This PR replaces
github.com/sanathkr/go-yamlwithgopkg.in/yaml.v3for ECS. Doing this require updating the AWS CloudFormation package fromv4.15.6tov7.3.2.The
github.com/sanathkr/go-yamlwas a fork and it was last updated in 2017. This library was added in #544, andgithub.com/awslabs/goformationwas also using the same library at that time. In AWS CloudFormation v7.2.0, they switched their YAML library togopkg.in/yaml.v3(awslabs/goformation#535)./test-ecs
(not mandatory) A picture of a cute animal, if possible in relation with what you did