Introduce ECS emulation mode #544
Conversation
ndeloof
changed the title
ndeloof
changed the title
ndeloof
changed the title
|
I'm stopping work on this waiting for discussion on UX to be applied here
|
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
simulation
branch
2 times, most recently
from
3e40d4e
to
c7b1591
Compare
ndeloof
changed the title
| @@ -27,6 +27,8 @@ import ( | |||
| "syscall" | |||
| "time" | |||
|
|
|||
| "github.com/docker/compose-cli/cli/cmd/compose" | |||
There was a problem hiding this comment.
lol our imports are all borked
Signed-off-by: Nicolas De Loof <[email protected]>
|
Is this ready to be reviewed or do we wait for tests? |
|
I consider this to be ready for review. Can add tests if requested but not sure what should be covered |
Signed-off-by: Nicolas De Loof <[email protected]>
| return cmd.Run() | ||
| } | ||
|
|
||
| func (e ecsLocalSimulation) Convert(ctx context.Context, project *types.Project) ([]byte, error) { |
There was a problem hiding this comment.
Maybe a unit test on the global Convert method ?
Regarding e2e tests, I would feel more confident if we could run a compose up/down in the CI in simulation mode, but this will require docker-compose available on top of the plain docker (and the right version) ; we need to check how to set this up, does not need to be a blocker for this PR
Signed-off-by: Nicolas De Loof <[email protected]>
|
better understanding after reading https://aws.amazon.com/blogs/compute/a-guide-to-locally-testing-containers-with-amazon-ecs-local-endpoints-and-docker-compose/. |
What I did
Introduce support for ECS simulation mode in the compose-cli with
up --simulationcommandRelated issue
https://github.com/docker/ecs-plugin/issues/210
(not mandatory) A picture of a cute animal, if possible in relation with what you did
