This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
do not forward signals to docker CLI #2267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
signal_forward
branch
from
5a89eab
to
b1eb351
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as a user hit Ctrl+C in a terminal, shell sends signal to all processes in the process group, so there's no need to forward signal to docker CLI when it is wrapped by cloud integrations. This has the side effect CLI receives duplicated signals
with a comparable architecture, docker/cli does NOT forward signals to CLI plugins for this exact reason