Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Tidying up some of the core OSCAL methods #44

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

anweiss
Copy link
Contributor

@anweiss anweiss commented Jan 14, 2019

Tidying up some of the core OSCAL methods. Accept io.Writer as appropriate. Removed CC0 Public Domain header from all source code files in favor of blanket LICENSE file at the root.

@anweiss anweiss self-assigned this Jan 14, 2019
@anweiss anweiss added the enhancement New feature or request label Jan 17, 2019
@anweiss anweiss changed the title [WIP] Tidying up some of the core OSCAL methods Tidying up some of the core OSCAL methods Jan 28, 2019
Copy link
Contributor

@asadullah-yousuf-10p asadullah-yousuf-10p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions.

types/oscal/oscal.go Outdated Show resolved Hide resolved
types/oscal/oscal.go Outdated Show resolved Hide resolved
@anweiss
Copy link
Contributor Author

anweiss commented Jan 28, 2019

@asadullah-yousuf-10p updated per your suggestions. Let me know what you think. Thanks.

minhaj10p
minhaj10p previously approved these changes Jan 28, 2019
Copy link
Contributor

@minhaj10p minhaj10p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadullah-yousuf-10p
Copy link
Contributor

LGTM.

@anweiss anweiss merged commit f0976b2 into docker-archive:master Jan 29, 2019
@anweiss anweiss deleted the core-oscal-cleanup branch January 29, 2019 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants