Skip to content

Commit

Permalink
Merge pull request #238 from mai-soup/patch-1
Browse files Browse the repository at this point in the history
fixing typos + unfinished sentence in part 2
  • Loading branch information
mluukkai authored Dec 19, 2023
2 parents cfb596a + 7b0c4f5 commit cec83ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions docs/part-2/section-3.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ services:
Note:
- `restart: always` was changed to `unless-stopped` that will keep the container running unless we explicitely stop it. With `always` the stopped container is started after reboot for example, see [here](https://docs.docker.com/config/containers/start-containers-automatically/) for more.
- `restart: always` was changed to `unless-stopped` that will keep the container running unless we explicitly stop it. With `always` the stopped container is started after reboot for example, see [here](https://docs.docker.com/config/containers/start-containers-automatically/) for more.

Under the section [Where to store data](https://github.com/docker-library/docs/blob/master/postgres/README.md#where-to-store-data) we can see that the `/var/lib/postgresql/data` should be mounted separately to preserve the data.

Expand Down Expand Up @@ -67,7 +67,7 @@ Let's **inspect** if there was a volume created with `docker container inspect d
"Destination": "/var/lib/postgresql/data",
```

An indeed there is one! So despite we did not configure anything the
An indeed there is one! So despite us not configuring one explicitly, an anonymous volume was automatically created for us.

Now if we check out `docker volume ls` we can see that a volume with name "794c9d8db6b5e643865c8364bf3b807b4165291f02508404ff3309b8ffde01df" exists.

Expand Down Expand Up @@ -99,7 +99,7 @@ volumes:
database:
```

Now let us check what it looks like:
Now, after running `docker compose up` again, let us check what it looks like:

```console
$ docker volume ls
Expand Down Expand Up @@ -230,7 +230,7 @@ Adminer actually assumes that the database has DNS name _db_ so with this name

Let us continue with the example app that we worked with in [Exercise 2.4](/part-2/section-2#exercise-24).

Now you should add database to example backend.
Now you should add a database to the example backend.

Use a Postgres database to save messages. For now there is no need to configure a volume since the official postgres image sets a default volume for us. Use the Postgres image documentation to your advantage when configuring: [https://hub.docker.com/\_/postgres/](https://hub.docker.com/_/postgres/). Especially part _Environment Variables_ is a valuable one.

Expand Down
2 changes: 1 addition & 1 deletion docs/part-2/section-4.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Containers are not only great in production. They can be used in development env

For an example, a [software development team](https://toska.dev/) at the University of Helsinki has a fully [containerized development environment](https://ethesis.helsinki.fi/repository/handle/123456789/30995). The principle in all development projects is to have a setup so that a new developer only needs to install Docker and clone the project code from GitHub to get started. Not a single dependency is ever installed on to host machine, Git, Docker and the text editor of choice is only thing that is needed.

Even if your application is not completely containerized during development, containers can very helpful. For example, say you need MongoDB version 4.0.22 installed in port 5656. It's now oneliner: "docker run -p 5656:27017 mongo:4.0.22" (MongoDB uses 27017 as default port).
Even if your application is not completely containerized during development, containers can very helpful. For example, say you need MongoDB version 4.0.22 installed in port 5656. It's now a oneliner: "docker run -p 5656:27017 mongo:4.0.22" (MongoDB uses 27017 as default port).

Let's containerize a NodeJS development environment. As you perhaps know [NodeJS](https://nodejs.org/en/) is a cross-platform JavaScript runtime that makes it possible to run JavaScript in your machine, servers and embedded devices, among many other platforms

Expand Down

0 comments on commit cec83ad

Please sign in to comment.