Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov (for now) #103

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Jul 10, 2024

It's been failing to upload for a while, and I don't think the failures are completely their fault (GitHub's got to share some of the blame, I think), but the end result is that we don't really have any good options for continuing to use the service (bad/unacceptable options include install an app with way too many privileges on the org/repo or add a "secret" with a personal access token ... and make that available to Pull Requests too 🙃).

It's been failing to upload for a while, and I don't think the failures are *completely* their fault (GitHub's got to share some of the blame, I think), but the end result is that we don't really have any good options for continuing to use the service (bad/unacceptable options include install an app with way too many privileges on the org/repo or add a "secret" with a personal access token ... and make that available to Pull Requests too 🙃).
@tianon tianon requested a review from yosifkit as a code owner July 10, 2024 19:21
Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@yosifkit
Copy link
Member

@yosifkit yosifkit merged commit 63bf7cf into docker-library:master Jul 10, 2024
6 checks passed
@yosifkit yosifkit deleted the codecov branch July 10, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants